added project layout, defined amp commands for server/client #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I finally mocked up some command's to use for the server-client communication. There might be some confusion about which command can be dispatched by the server/client and which can't. Thats why I added the abstraction Layer so there is the option of checking with in e.g. isinstance() if the command is allowed to be send in the direction. |
Raining-Cloud
requested review from
luator,
PacoSchatz and
Cari1111
and removed request for
luator
Raining-Cloud
changed the title
Cari1111
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two folders for the server and client software, so we don't mix up the code/packages. In addition to that I started with @Cari1111 to design the commands which usethe twisted amp protocol, more details in the wiki.
Implements #20